bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: ACLs on HP NonStop


From: Schmitz, Joachim
Subject: RE: ACLs on HP NonStop
Date: Sun, 3 Oct 2010 15:57:38 +0200

+ setacl -s user::6,group::0,other::0 tmpfile0
unknown permission ":0"

I think that should rather be

setacl -s user::6,group::0,other:0 tmpfile0

But that gives:
$ setacl -s user::6,group::0,other:0 tmpfile0
required entry for file owner, file group, "class", or "other" not specified

usage: setacl [-n] {-m|-d} acl_entries [{-m|-d} acl_entries]... object(s)
   or: setacl [-n] -s acl_entries object(s)
   or: setacl [-n] -f file_name object(s)

   where acl_entries for various options are as follows:
   -m : {[d[efault]:]u[ser]::{operm|perm}|
         [d[efault]:]u[ser]:uid:{operm|perm}|
         [d[efault]:]g[roup]::{operm|perm}|
         [d[efault]:]g[roup]:gid:{operm|perm}|
         [d[efault]:]c[lass]:{operm|perm}|
         [d[efault]:]o[ther]:{operm|perm}}[,...]

   -d : {[d[efault]:]u[ser]:uid|
         [d[efault]:]g[roup]:gid|
         [d[efault]:]u[ser]::|
         [d[efault]:]g[roup]::|
         [d[efault]:]c[lass]:|
         [d[efault]:]o[ther]:}[,...]

   -s : u[ser]::{operm|perm}[,...]
        [d[efault]:u[ser]::{operm|perm}[,...]]
        g[roup]::{operm|perm}[,...]
        [d[efault]:g[roup]::{operm|perm}[,...]]
        c[lass]:{operm|perm}[,...]
        [d[efault]:c[lass]:{operm|perm}[,...]]
        o[ther]:{operm|perm}[,...]
        [d[efault]:o[ther]:{operm|perm}[,...]]
        [[d[efault]:]u[ser]:uid:{operm|perm}[,...]]
        [[d[efault]:]g[roup]:gid:{operm|perm}[,...]]

So it is still wrong. (you see though that only user and group have the double 
":", class and other have only one)
Ah, now I see, 'class' is mandatory, so we'd need
 
setacl -s user::6,group::0,class:0,other:0 tmpfile0

Patch:
diff -u ./gltests/test-copy-acl.sh.orig ./gltests/test-copy-acl.sh
--- ./gltests/test-copy-acl.sh.orig     2010-10-03 06:00:33.000000000 -0500
+++ ./gltests/test-copy-acl.sh  2010-10-03 08:46:07.000000000 -0500
@@ -446,7 +446,7 @@

         # Delete all optional ACLs.
         setacl -m user:$auid:1 tmpfile0
-        setacl -s user::6,group::0,other::0 tmpfile0
+        setacl -s user::6,group::0,class:0,other:0 tmpfile0

         func_test_copy tmpfile0 tmpfile8

diff -u ./gltests/test-copy-file.sh.orig ./gltests/test-copy-file.sh
--- ./gltests/test-copy-file.sh.orig    2010-10-03 06:01:34.000000000 -0500
+++ ./gltests/test-copy-file.sh 2010-10-03 08:48:03.000000000 -0500
@@ -440,7 +440,7 @@

         # Delete all optional ACLs.
         setacl -m user:$auid:1 tmpfile0
-        setacl -s user::6,group::0,other::0 tmpfile0
+        setacl -s user::6,group::0,class:0,other:0 tmpfile0

         func_test_copy tmpfile0 tmpfile8


and that indeed works:
PASS: test-file-has-acl.sh
PASS: test-set-mode-acl.sh
PASS: test-copy-acl.sh
PASS: test-binary-io.sh
PASS: test-copy-file.sh
PASS: test-errno
PASS: test-fcntl-h
PASS: test-ftello.sh
PASS: test-ftello2.sh
PASS: test-ftello3
PASS: test-lseek.sh
PASS: test-lstat
PASS: test-mbrtowc1.sh
Skipping test: no french Unicode locale is supported
SKIP: test-mbrtowc2.sh
Skipping test: no traditional japanese locale is supported
SKIP: test-mbrtowc3.sh
Skipping test: no transitional chinese locale is supported
SKIP: test-mbrtowc4.sh
Skipping test: no french Unicode locale is supported
SKIP: test-mbsinit.sh
PASS: test-open
PASS: test-quotearg-simple
Read 68 from /etc/resolv.conf...
FAIL: test-read-file
PASS: test-stat
PASS: test-stdbool
PASS: test-stddef
PASS: test-stdint
PASS: test-stdio
PASS: test-stdlib
PASS: test-strerror
PASS: test-string
PASS: test-symlink
PASS: test-sys_stat
PASS: test-time
PASS: test-unistd
PASS: test-verify
PASS: test-verify.sh
PASS: test-wchar
PASS: test-wctype
PASS: test-xalloc-die.sh
======================
1 of 33 tests failed
(4 tests were not run)
======================


Now hunting that failed check... ah, /etc/resolv.conf is a symlink here, 
apparently the test doesn't like this. Patch:
diff -u ./gltests/test-read-file.c.orig ./gltests/test-read-file.c
--- ./gltests/test-read-file.c.orig     2010-01-31 10:29:44.000000000 -0600
+++ ./gltests/test-read-file.c  2010-10-03 08:55:44.000000000 -0500
@@ -23,7 +23,11 @@
 #include <stdlib.h>
 #include <sys/stat.h>

+#ifdef __TANDEM
+#define FILE1 "/etc/profile"
+#else
 #define FILE1 "/etc/resolv.conf"
+#endif
 #define FILE2 "/dev/null"

 Int


Now all tests pass!
======================
All 33 tests passed
(4 tests were not run)
======================

Bye, Jojo
-----Original Message-----
From: Bruno Haible [mailto:address@hidden 
Sent: Sunday, October 03, 2010 3:14 PM
To: Schmitz, Joachim
Cc: 'Paolo Bonzini'; 'bug-gnulib'
Subject: Re: ACLs on HP NonStop

Joachim Schmitz wrote:
> Looks much better now. 'make check' now reports:
> PASS: test-file-has-acl.sh
> PASS: test-set-mode-acl.sh

Very nice! These are usually the hardest ones to make pass on a new platform.

> unknown permission ":0"
> PASS: test-copy-acl.sh
> unknown permission ":0"
> PASS: test-copy-file.sh

Can you do "VERBOSE=1 make check TESTS=test-copy-acl.sh" ?
This should show where the 'unknown permission ":0"' comes from.
Maybe you can also find out how to correct this problem in the test?

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]