[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fwd: sed porting trouble
From: |
Jim Meyering |
Subject: |
Re: Fwd: sed porting trouble |
Date: |
Sat, 02 Oct 2010 08:33:39 +0200 |
Paul Eggert wrote:
> On 10/01/2010 06:25 AM, Paolo Bonzini wrote:
>
>> So, it looks like we must make sure that the system-header
>> replacements have 80-columns lines. Sigh.
>
> I agree about the "Sigh", but it's better to do that than to play with
> unportable #pragmas. Besides, those header files with the long lines
> are too hard to read anyway. I can't easily parse this:
>
> #if defined __need_mbstate_t || defined __need_wint_t || (defined __hpux &&
> ((defined _INTTYPES_INCLUDED && !defined strtoimax) || defined
> _GL_JUST_INCLUDE_SYSTEM_WCHAR_H)) || defined _GL_ALREADY_INCLUDING_WCHAR_H
>
> and would far prefer seeing that line folded into 80 characters, so I
> can figure out what it means.
Definitely an improvement.
> So, how about something like the following patch? It will fix the
> immediate problem anyway. (And my goodness, what a terrible misfeature
> "#pragma COLUMN" is! would you all mind if I give it as an example of a
> terrible design in my programming languages class?)
Considering that "#pragma COLUMN" has provoked this patch,
perhaps it is really a very cleverly designed feature ;-)
- Re: multiline substitutions, (continued)
- Re: Fwd: sed porting trouble, Eric Blake, 2010/10/05
- Re: minimum automake version, Bruno Haible, 2010/10/05
- Re: Fwd: sed porting trouble, Simon Josefsson, 2010/10/05
- Re: Fwd: sed porting trouble, Bruno Haible, 2010/10/05
- Re: Fwd: sed porting trouble, Paul Eggert, 2010/10/04
- Re: Fwd: sed porting trouble, Jim Meyering, 2010/10/05
- Re: Fwd: sed porting trouble, Paul Eggert, 2010/10/01
- Re: Fwd: sed porting trouble,
Jim Meyering <=
- RE: Fwd: sed porting trouble, Schmitz, Joachim, 2010/10/02
- Re: Fwd: sed porting trouble, Paolo Bonzini, 2010/10/02
- Re: Fwd: sed porting trouble, Bruno Haible, 2010/10/02
- RE: Fwd: sed porting trouble, Schmitz, Joachim, 2010/10/02
- Re: Fwd: sed porting trouble, Bruno Haible, 2010/10/02
- RE: Fwd: sed porting trouble, Schmitz, Joachim, 2010/10/02
- Re: Fwd: sed porting trouble, Paul Eggert, 2010/10/03
- Re: Fwd: sed porting trouble, Bruno Haible, 2010/10/03
- Re: Fwd: sed porting trouble, Bruno Haible, 2010/10/02
- RE: Fwd: sed porting trouble, Schmitz, Joachim, 2010/10/02