|
From: | Eric Blake |
Subject: | Re: [PATCH] init.sh: disqualify shells for which set -x corrupts stderr |
Date: | Wed, 08 Sep 2010 08:58:11 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Mnenhy/0.8.3 Thunderbird/3.1.2 |
On 09/08/2010 08:45 AM, Jim Meyering wrote:
If bash is manually installed, then things are okay. But all existing shells on a bare-bones installation output trace information.If that happens, the result will be that each init.sh-using test will be skipped.
Fair enough - someone with enough incentive to test on that type of platform can resolve the issue by manually installing a better shell, particularly if the skip message hints at that being the problem.
Polluting our code, even "mere" tests, solely to accommodate an inferior or old system is hard for me to justify. I think it scales better simply to eliminate the offending shells -- then we avoid the constant overhead of auditing for yet another portability nit.
Seems reasonable - give ourselves the guarantee now, and if it proves to strict, then back it out and do the audit then, rather than spending time on the audit now.
Besides, isn't Irix 5.x approaching effective museum-only status?
Probably, but I don't (yet) have access to Irix 6.5 to test a newer version of that platform.
-- Eric Blake address@hidden +1-801-349-2682 Libvirt virtualization library http://libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |