bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] lseek: fix link test


From: Eric Blake
Subject: [PATCH] lseek: fix link test
Date: Thu, 26 Aug 2010 16:23:34 -0600

Another bug spotted by autoconf.

* m4/lseek.m4 (gl_FUNC_LSEEK): Use correct format for
AC_LINK_IFELSE.

Signed-off-by: Eric Blake <address@hidden>
---

This is the last buggy use spotted among coreutils' choice of modules;
but there are probably others lurking in gnulib.  I haven't yet tried
if gnulib-tool --create-megatestdir will flush them out...

 ChangeLog   |    4 ++++
 m4/lseek.m4 |   14 ++++++--------
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 146e522..af835b6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2010-08-26  Eric Blake  <address@hidden>

+       lseek: fix link test
+       * m4/lseek.m4 (gl_FUNC_LSEEK): Use correct format for
+       AC_LINK_IFELSE.
+
        include_next: silence autoconf 2.68 warning
        * m4/include_next.m4 (gl_INCLUDE_NEXT): Mark this use of
        AC_COMPILE_IFELSE as special.
diff --git a/m4/lseek.m4 b/m4/lseek.m4
index 9bf4dc2..b0612c7 100644
--- a/m4/lseek.m4
+++ b/m4/lseek.m4
@@ -1,4 +1,4 @@
-# lseek.m4 serial 5
+# lseek.m4 serial 6
 dnl Copyright (C) 2007, 2009, 2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -10,15 +10,13 @@ AC_DEFUN([gl_FUNC_LSEEK],
   AC_REQUIRE([AC_PROG_CC])
   AC_CACHE_CHECK([whether lseek detects pipes], [gl_cv_func_lseek_pipe],
     [if test $cross_compiling = no; then
-       AC_LINK_IFELSE([
+       AC_LINK_IFELSE([AC_LANG_PROGRAM([[
 #include <sys/types.h> /* for off_t */
 #include <stdio.h> /* for SEEK_CUR */
-#include <unistd.h>
-int main ()
-{
+#include <unistd.h>]], [[
   /* Exit with success only if stdin is seekable.  */
   return lseek (0, (off_t)0, SEEK_CUR) < 0;
-}],
+]])],
          [if test -s conftest$ac_exeext \
              && ./conftest$ac_exeext < conftest.$ac_ext \
              && test 1 = "`echo hi \
@@ -29,11 +27,11 @@ int main ()
           fi],
          [gl_cv_func_lseek_pipe=no])
      else
-       AC_COMPILE_IFELSE([
+       AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
 #if ((defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__) || defined 
__BEOS__
 /* mingw and BeOS mistakenly return 0 when trying to seek on pipes.  */
   Choke me.
-#endif],
+#endif]])],
          [gl_cv_func_lseek_pipe=yes], [gl_cv_func_lseek_pipe=no])
      fi])
   if test $gl_cv_func_lseek_pipe = no; then
-- 
1.7.2.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]