bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] test-linkat: avoid failed assertion on "other" architectures


From: Jim Meyering
Subject: [PATCH] test-linkat: avoid failed assertion on "other" architectures
Date: Fri, 11 Jun 2010 09:18:21 +0200

I noticed this patch go into launchpad against coreutils,
but it affects gnulib, so here we go.

This is a strong argument for enabling -Werror when compiling tests.
Even on Fedora 13, these warnings have been flying by:

  test-link.h:47:5: warning: implicit declaration of function 'stat' 
[-Wimplicit-function-declaration]
  test-link.h:98:3: warning: implicit declaration of function 'mkdir' 
[-Wimplicit-function-declaration]
  test-linkat.c:65:3: warning: implicit declaration of function 'lstat' 
[-Wimplicit-function-declaration]

but I had not noticed them.

>From 0ffbddbdbe959fd8ea3cc18cb4d1c89686e6b2bb Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 11 Jun 2010 08:50:08 +0200
Subject: [PATCH] test-linkat: avoid failed assertion on "other" architectures

* tests/test-linkat.c: Include <sys/stat.h>, for lstat declaration.
Patch by John Rigby, to fix FTBFS on armel, powerpc, sparc:
https://bugs.launchpad.net/bugs/591968

2010-06-11  Jim Meyering  <address@hidden>
---
 ChangeLog           |    7 +++++++
 tests/test-linkat.c |    1 +
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0e27cc7..4108097 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2010-06-11  Jim Meyering  <address@hidden>

+       test-linkat: avoid failed assertion on "other" architectures
+       * tests/test-linkat.c: Include <sys/stat.h>, for lstat declaration.
+       Patch by John Rigby, to fix FTBFS on armel, powerpc, sparc:
+       https://bugs.launchpad.net/bugs/591968
+
+2010-06-11  Jim Meyering  <address@hidden>
+
        printf.m4: avoid autoconf's "Expanded Before Required" warning
        * m4/printf.m4 (gl_SNPRINTF_RETVAL_C99): Define using AC_DEFUN_ONCE,
        rather than AC_DEFUN, to avoid the classic "Expanded Before Required"
diff --git a/tests/test-linkat.c b/tests/test-linkat.c
index 1dbfad5..cee1c99 100644
--- a/tests/test-linkat.c
+++ b/tests/test-linkat.c
@@ -29,6 +29,7 @@ SIGNATURE_CHECK (linkat, int, (int, char const *, int, char 
const *, int));
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <sys/stat.h>

 #include "areadlink.h"
 #include "filenamecat.h"
--
1.7.1.501.g23b46



reply via email to

[Prev in Thread] Current Thread [Next in Thread]