bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

maint.mk sc_prohibit_always-defined_macros complains about build-aux/war


From: Martin von Gagern
Subject: maint.mk sc_prohibit_always-defined_macros complains about build-aux/warn-on-use.h
Date: Tue, 25 May 2010 22:21:52 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100411 Thunderbird/3.0.4

Hi there!

I've got gnulib in my repository, so devs don't need a git checkout.
When I last ran the syntax checks from maint.mk, I got a false positive
from prohibit_always-defined_macros complaining about the definition of
environ in build-aux/warn-on-use.h.

The error is due to the following line in warn-on-use.h
   # define environ (*rpl_environ ())
which conflicts with definitions from unistd.in.h.

Maybe you should alter that file so it doesn't match the rule. Or you
should explicitely exclude it from the list of files to check.

In my package, wdiff, I've excluded the whole build-aux directory from
that check, but I can easily do so without creating extra files due to
my personal modifications to gnulib.
http://github.com/gagern/gnulib/commit/57646d674f68676ca3b9
I guess I should try to get my gnulib copyright assignment forms
completed so you can include this upstream as well...

Greetings,
 Martin von Gagern

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]