bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BLOCKER] cannot single-step unit tests any more


From: Bruno Haible
Subject: Re: [BLOCKER] cannot single-step unit tests any more
Date: Sun, 16 May 2010 21:55:09 +0200
User-agent: KMail/1.9.9

Hi Jim,

> Now I've tried harder, and this does the job:

Thanks a lot for getting to this so quickly! I can now single-step through
the test in the documented way.

One line in the patch looks strange: In the test whether the current shell
is OK you test for an exit code 9; then in the loop you test for exit code 2.
In view of your comment about Solaris /bin/sh and exit code 2, I think you
meant the following:

--- tests/init.sh.orig  Sun May 16 21:50:43 2010
+++ tests/init.sh       Sun May 16 21:50:14 2010
@@ -96,7 +96,8 @@
       test "$re_shell_" = no_shell && continue
       test "$re_shell_" = fail && skip_ failed to find an adequate shell
       "$re_shell_" -c "$gl_shell_test_script_" 2>/dev/null
-      if test $? = 2; then
+      if test $? = 9; then
+        # Found a better shell than the current one.
         exec "$re_shell_" "$0" --no-reexec "$@"
         echo "$ME_: exec failed" 1>&2
         exit 127

No?

Bruno



reply via email to

[Prev in Thread] Current Thread [Next in Thread]