bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Do not limit git-version-gen to work only under the reposito


From: Bruno Haible
Subject: Re: [PATCH] Do not limit git-version-gen to work only under the repository root.
Date: Mon, 10 May 2010 11:27:42 +0200
User-agent: KMail/1.9.9

Hello Giuseppe,

> +elif git describe > /dev/null 2>&1 \

If 'git' is not found in PATH, this line would yield an error message in some
shells. To avoid that, run the command in a sub-shell:
  elif (git describe) > /dev/null 2>&1 \

> * build-aux/git-version-gen: Check if it is a git repository using the
> "git status" command instead of test'ing the .git directory presence.
> +     * build-aux/git-version-gen: Check if it is a git repository using the
> +     "git status" command instead of test'ing the .git directory presence.

The ChangeLog and commit message don't reflect what the patch is doing.

Otherwise, your patch works fine for me (but I'm not a 'git' expert).

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]