[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] verify: adjust formatting to be more consistent
From: |
Bruno Haible |
Subject: |
Re: [PATCH] verify: adjust formatting to be more consistent |
Date: |
Sun, 9 May 2010 12:26:28 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Jim,
> @@ -71,7 +71,7 @@
>
> #define _GL_CONCAT0(x, y) x##y
> #define _GL_CONCAT(x, y) _GL_CONCAT0 (x, y)
> - extern struct {...} * _GL_CONCAT(dummy,__LINE__);
> + extern struct {...} * _GL_CONCAT (dummy, __LINE__);
>
> But this has the problem that two invocations of verify from
> within the same macro would collide, since the __LINE__ value
I have no objection against this patch. Just a note that my personal
preference is to emphasize the token-pasting effect of such macros
by _not_ putting spaces there. See
<http://lists.gnu.org/archive/html/bug-gnulib/2010-03/msg00257.html>
Bruno