[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint.mk: syntax-check: prohibit HAVE_<header>_H that are al
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] maint.mk: syntax-check: prohibit HAVE_<header>_H that are always true |
|
Date: |
Tue, 27 Apr 2010 14:29:38 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
On 27/04/10 13:15, Jim Meyering wrote:
> I've just pushed the patch below.
> It exposed a few unnecessary #if tests in coreutils:
Very nice check.
> Hence the compromise of searching for all of them at once,
> with the downside that occasionally you'll be warned about
> a line like this one (from the patch above)
>
> # if HAVE_NETINET_IN_H && HAVE_NFS_NFS_CLNT_H && HAVE_NFS_VFS_H
>
> and it'll be up to you to determine which it's talking about.
That should be good enough.
cheers,
Pádraig.