Re: link-warning usage improvements

[Bruno Haible]

Eric Blake wrote:
> But your fix is also incomplete.  For example:
> 
> > --- 306,315 ----
> >        __THROW _GL_ARG_NONNULL ((1, 2));
> >   # endif
> >   #elif defined GNULIB_POSIXCHECK
> > ! # undef posix_spawnattr_getflags
> > ! # define posix_spawnattr_getflags(a, b)                         \
> > !   (GL_LINK_WARNING ("posix_spawnattr_getflags is unportable - "        \
> > !                     "use gnulib module posix_spawnattr_getflags for 
> portability"), \
> >      posix_spawnattr_getsigdefault (a, b))
> 
> this issues the warning for posix_spawnattr_getflags, but calls 
> posix_spawnattr_getsigdefault.

Oops, yes. Thanks for cross-reviewing my commit. This should fix it:


2009-12-31  Bruno Haible  <address@hidden>

        spawn: Fix incomplete fix.
        * lib/spawn.in.h (posix_spawnattr_getflags, posix_spawnattr_setflags,
        posix_spawnattr_getpgroup, posix_spawnattr_setpgroup): Correct the link
        warnings for GNULIB_POSIXCHECK again.
        Reported by Eric Blake.

--- lib/spawn.in.h.orig Thu Dec 31 23:29:21 2009
+++ lib/spawn.in.h      Thu Dec 31 23:27:53 2009
@@ -315,7 +315,7 @@
 # define posix_spawnattr_getflags(a, b)                         \
   (GL_LINK_WARNING ("posix_spawnattr_getflags is unportable - "        \
                     "use gnulib module posix_spawnattr_getflags for 
portability"), \
-   posix_spawnattr_getsigdefault (a, b))
+   posix_spawnattr_getflags (a, b))
 #endif
 
 #if @GNULIB_POSIX_SPAWNATTR_SETFLAGS@
@@ -333,7 +333,7 @@
 # define posix_spawnattr_setflags(a, b)                         \
   (GL_LINK_WARNING ("posix_spawnattr_setflags is unportable - "        \
                     "use gnulib module posix_spawnattr_setflags for 
portability"), \
-   posix_spawnattr_getflags (a, b))
+   posix_spawnattr_setflags (a, b))
 #endif
 
 #if @GNULIB_POSIX_SPAWNATTR_GETPGROUP@
@@ -351,7 +351,7 @@
 # define posix_spawnattr_getpgroup(a, b)                         \
   (GL_LINK_WARNING ("posix_spawnattr_getpgroup is unportable - "        \
                     "use gnulib module posix_spawnattr_getpgroup for 
portability"), \
-   posix_spawnattr_setflags (a, b))
+   posix_spawnattr_getpgroup (a, b))
 #endif
 
 #if @GNULIB_POSIX_SPAWNATTR_SETPGROUP@
@@ -369,7 +369,7 @@
 # define posix_spawnattr_setpgroup(a, b)                         \
   (GL_LINK_WARNING ("posix_spawnattr_setpgroup is unportable - "        \
                     "use gnulib module posix_spawnattr_setpgroup for 
portability"), \
-   posix_spawnattr_setflags (a, b))
+   posix_spawnattr_setpgroup (a, b))
 #endif
 
 #if @GNULIB_POSIX_SPAWNATTR_GETSCHEDPOLICY@