[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: link-warning usage improvements
From: |
Eric Blake |
Subject: |
Re: link-warning usage improvements |
Date: |
Thu, 31 Dec 2009 21:25:20 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
Bruno Haible <bruno <at> clisp.org> writes:
> Looks like some part of this patch was misapplied:
posix_spawnattr_getsigdefault
> gets a link warning twice, and some others under the wrong #elif. I'm applying
> this fix:
But your fix is also incomplete. For example:
> --- 306,315 ----
> __THROW _GL_ARG_NONNULL ((1, 2));
> # endif
> #elif defined GNULIB_POSIXCHECK
> ! # undef posix_spawnattr_getflags
> ! # define posix_spawnattr_getflags(a, b) \
> ! (GL_LINK_WARNING ("posix_spawnattr_getflags is unportable - " \
> ! "use gnulib module posix_spawnattr_getflags for
portability"), \
> posix_spawnattr_getsigdefault (a, b))
this issues the warning for posix_spawnattr_getflags, but calls
posix_spawnattr_getsigdefault. I'll commit a followup if you don't beat me to
it.
I'm sorry about all this. I was obviously too hasty this morning, and ended up
pushing several flawed patches.
--
Eric Blake
- link-warning usage improvements, Eric Blake, 2009/12/24
- Re: link-warning usage improvements, Bruno Haible, 2009/12/31
- Re: link-warning usage improvements, Bruno Haible, 2009/12/31
- Re: link-warning usage improvements, Eric Blake, 2009/12/31
- Re: link-warning usage improvements, Eric Blake, 2009/12/31
- Re: link-warning usage improvements, Bruno Haible, 2009/12/31
- Re: link-warning usage improvements, Eric Blake, 2009/12/31
- Re: link-warning usage improvements, Eric Blake, 2009/12/31