[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] test-freading: remove a temporary file
From: |
Jim Meyering |
Subject: |
Re: [PATCH] test-freading: remove a temporary file |
Date: |
Sun, 15 Nov 2009 17:21:11 +0100 |
Bruno Haible wrote:
>> Without this change, this test's temporary file is left behind every
>> time it is run.
>>
>> Any objection?
>
> The #include and the first unlink are fine. Thanks, well spotted.
>
> The second unlink is better omitted, since when the message "file operations
> failed"
> message is printed, the user will likely want to inspect the contents of the
> file and fix
> the test.
Hi Bruno,
I think it's better to clean up unconditionally.
Anyone who is serious about investigating a failure can be
expected to run the debugger.
Since Eric wrote that test, it's his call.