bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: test-bitrotate failure on Solaris


From: Simon Josefsson
Subject: Re: test-bitrotate failure on Solaris
Date: Thu, 27 Aug 2009 17:17:11 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

Bruno Haible <address@hidden> writes:

> Hi,
>
> On Solaris/x86, with SunPRO C 5.9, the test-bitrotate fails:
>
>   test-bitrotate.c:227: assertion failed
>   FAIL: test-bitrotate
>
> The reason is that test-bitrotate.c:227 passes a 0 shift count to rotr64,
> which is outside the specification of rotr64.
>
> I propose to remove that particular test:

Seems fine, please push it.  Thanks.

/Simon

>
> 2009-08-27  Bruno Haible  <address@hidden>
>
>       * tests/test-bitrotate.c (main): Remove test that uses a shift count
>       of 0.
>
> --- tests/test-bitrotate.c.orig       2009-08-27 10:00:56.000000000 +0200
> +++ tests/test-bitrotate.c    2009-08-27 10:00:32.000000000 +0200
> @@ -1,5 +1,5 @@
>  /* Test of <bitrotate.h> substitute.
> -   Copyright (C) 2007-2008 Free Software Foundation, Inc.
> +   Copyright (C) 2007-2009 Free Software Foundation, Inc.
>  
>     This program is free software: you can redistribute it and/or modify
>     it under the terms of the GNU General Public License as published by
> @@ -224,7 +224,6 @@
>    ASSERT (rotl64 (16045690984503098046ULL, 62) == 13234794782980550319ULL);
>    ASSERT (rotl64 (16045690984503098046ULL, 63) == 8022845492251549023ULL);
>  
> -  ASSERT (rotr64 (16045690984503098046ULL, 0) == 16045690984503098046ULL);
>    ASSERT (rotr64 (16045690984503098046ULL, 1) == 8022845492251549023ULL);
>    ASSERT (rotr64 (16045690984503098046ULL, 2) == 13234794782980550319ULL);
>    ASSERT (rotr64 (16045690984503098046ULL, 3) == 15840769428345050967ULL);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]