[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
overly zealous git hook
From: |
Bruno Haible |
Subject: |
overly zealous git hook |
Date: |
Mon, 20 Jul 2009 01:43:32 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Jim,
The git server at savannah now rejects the normal form of module
descriptions. I got this error message:
modules/pipe-filter:34: ends with blank lines.
error: hooks/update exited with error code 2
error: hook declined to update refs/heads/master
I understand that for .c, .h, .texi and many other files, a blank line
at the end of the file is an indication of sloppiness. Not so for
gnulib module description files.
A gnulib modules description formally consists of sections. Every section
consists of one or more lines. The first line of a section is a special
keyword, followed by a colon (such as 'Makefile.am:'). Then comes a number
of content lines. At the end comes - by convention - a blank line. The
sections are in arbitrary order.
Because a blank line actually belongs to the section that started before
it (see how it's parsed in gnulib-tool: variable sed_extract_prog), it's
not a separator. Therefore it's perfectly normal that module descriptions
end in 1 blank line.
Likewise for ChangeLog files: They consist of entries, each ending with a
blank line. Therefore, normally, a ChangeLog file ends with a blank line.
Can you please exempt the files under modules/ and the ChangeLog files
from this hooks/update check?
Bruno
- overly zealous git hook,
Bruno Haible <=