Re: [PATCH 2/4] Use SA_ONSTACK even if SA_SIGINFO is unavailable.

[Paolo Bonzini]

Eric Blake wrote:
> Ingo Weinhold <ingo_weinhold <at> gmx.de> writes:
> 
>> If SA_ONSTACK exists, use it even if SA_SIGINFO doesn't. This does at least
>> allow for a somewhat controlled program termination on stack overflow. E.g.
>> in Haiku this prevents the debug server dialog box from popping up.
> 
> In my mind, it would be cleaner if we provided a stub
> 
> #ifndef SA_SIGINFO
> # define SA_SIGINFO 0
> #endif
> 
> in signal.in.h rather than using #if inside the body of a method, similar to 
> the SA_NODEFER stub added for Interix.  Does that approach work for you?

It would be actually a stub

#ifndef SA_ONSTACK
# define SA_ONSTACK 0
#endif

but yes, I agree with Eric.

Paolo