bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: stdlib: provide random_data for mingw


From: Bruno Haible
Subject: Re: stdlib: provide random_data for mingw
Date: Sun, 26 Oct 2008 13:53:29 +0200
User-agent: KMail/1.5.4

Simon Josefsson wrote:
>    gl_CHECK_NEXT_HEADERS([stdlib.h])
>    AC_CHECK_TYPES([struct random_data], [], [], [[#include <stdlib.h>]])
> +  if test $ac_cv_type_struct_random_data = yes; then
> +    HAVE_STRUCT_RANDOM_DATA=1
> +  else
> +    HAVE_STRUCT_RANDOM_DATA=0
> +  fi
>  ])

Thanks. I'm adding this tweak to match the usual coding style: Initialize the
HAVE_STRUCT_RANDOM_DATA variable to 1, and set it to 0 when we see it's
missing. This looks pointless in this case, but is a useful convention when a
HAVE_* variable needs to be set to 0 at various places, for various possible
reasons (see e.g. REPLACE_CLOSE and gl_REPLACE_CLOSE).

Bruno


2008-10-26  Bruno Haible  <address@hidden>

        * m4/stdlib_h.m4 (gl_STDLIB_H_DEFAULTS): Set default of
        HAVE_STRUCT_RANDOM_DATA to 1.
        (gl_STDLIB_H): Simplify.

*** m4/stdlib_h.m4.orig 2008-10-26 12:36:24.000000000 +0100
--- m4/stdlib_h.m4      2008-10-26 12:34:33.000000000 +0100
***************
*** 8,19 ****
  [
    AC_REQUIRE([gl_STDLIB_H_DEFAULTS])
    gl_CHECK_NEXT_HEADERS([stdlib.h])
!   AC_CHECK_TYPES([struct random_data], [], [], [[#include <stdlib.h>]])
!   if test $ac_cv_type_struct_random_data = yes; then
!     HAVE_STRUCT_RANDOM_DATA=1
!   else
!     HAVE_STRUCT_RANDOM_DATA=0
!   fi
  ])
  
  AC_DEFUN([gl_STDLIB_MODULE_INDICATOR],
--- 8,16 ----
  [
    AC_REQUIRE([gl_STDLIB_H_DEFAULTS])
    gl_CHECK_NEXT_HEADERS([stdlib.h])
!   AC_CHECK_TYPES([struct random_data],
!     [], [HAVE_STRUCT_RANDOM_DATA=0],
!     [[#include <stdlib.h>]])
  ])
  
  AC_DEFUN([gl_STDLIB_MODULE_INDICATOR],
***************
*** 42,65 ****
    GNULIB_STRTOULL=0;      AC_SUBST([GNULIB_STRTOULL])
    GNULIB_UNSETENV=0;      AC_SUBST([GNULIB_UNSETENV])
    dnl Assume proper GNU behavior unless another module says otherwise.
!   HAVE_ATOLL=1;           AC_SUBST([HAVE_ATOLL])
!   HAVE_CALLOC_POSIX=1;    AC_SUBST([HAVE_CALLOC_POSIX])
!   HAVE_GETSUBOPT=1;       AC_SUBST([HAVE_GETSUBOPT])
!   HAVE_MALLOC_POSIX=1;    AC_SUBST([HAVE_MALLOC_POSIX])
!   HAVE_MKDTEMP=1;         AC_SUBST([HAVE_MKDTEMP])
!   HAVE_REALLOC_POSIX=1;   AC_SUBST([HAVE_REALLOC_POSIX])
!   HAVE_RANDOM_R=1;        AC_SUBST([HAVE_RANDOM_R])
!   HAVE_RPMATCH=1;         AC_SUBST([HAVE_RPMATCH])
!   HAVE_SETENV=1;          AC_SUBST([HAVE_SETENV])
!   HAVE_STRTOD=1;          AC_SUBST([HAVE_STRTOD])
!   HAVE_STRTOLL=1;         AC_SUBST([HAVE_STRTOLL])
!   HAVE_STRTOULL=1;        AC_SUBST([HAVE_STRTOULL])
!   HAVE_STRUCT_RANDOM_DATA=0;   AC_SUBST([HAVE_STRUCT_RANDOM_DATA])
!   HAVE_SYS_LOADAVG_H=0;   AC_SUBST([HAVE_SYS_LOADAVG_H])
!   HAVE_UNSETENV=1;        AC_SUBST([HAVE_UNSETENV])
!   HAVE_DECL_GETLOADAVG=1; AC_SUBST([HAVE_DECL_GETLOADAVG])
!   REPLACE_MKSTEMP=0;      AC_SUBST([REPLACE_MKSTEMP])
!   REPLACE_PUTENV=0;       AC_SUBST([REPLACE_PUTENV])
!   REPLACE_STRTOD=0;       AC_SUBST([REPLACE_STRTOD])
!   VOID_UNSETENV=0;        AC_SUBST([VOID_UNSETENV])
  ])
--- 39,62 ----
    GNULIB_STRTOULL=0;      AC_SUBST([GNULIB_STRTOULL])
    GNULIB_UNSETENV=0;      AC_SUBST([GNULIB_UNSETENV])
    dnl Assume proper GNU behavior unless another module says otherwise.
!   HAVE_ATOLL=1;              AC_SUBST([HAVE_ATOLL])
!   HAVE_CALLOC_POSIX=1;       AC_SUBST([HAVE_CALLOC_POSIX])
!   HAVE_GETSUBOPT=1;          AC_SUBST([HAVE_GETSUBOPT])
!   HAVE_MALLOC_POSIX=1;       AC_SUBST([HAVE_MALLOC_POSIX])
!   HAVE_MKDTEMP=1;            AC_SUBST([HAVE_MKDTEMP])
!   HAVE_REALLOC_POSIX=1;      AC_SUBST([HAVE_REALLOC_POSIX])
!   HAVE_RANDOM_R=1;           AC_SUBST([HAVE_RANDOM_R])
!   HAVE_RPMATCH=1;            AC_SUBST([HAVE_RPMATCH])
!   HAVE_SETENV=1;             AC_SUBST([HAVE_SETENV])
!   HAVE_STRTOD=1;             AC_SUBST([HAVE_STRTOD])
!   HAVE_STRTOLL=1;            AC_SUBST([HAVE_STRTOLL])
!   HAVE_STRTOULL=1;           AC_SUBST([HAVE_STRTOULL])
!   HAVE_STRUCT_RANDOM_DATA=1; AC_SUBST([HAVE_STRUCT_RANDOM_DATA])
!   HAVE_SYS_LOADAVG_H=0;      AC_SUBST([HAVE_SYS_LOADAVG_H])
!   HAVE_UNSETENV=1;           AC_SUBST([HAVE_UNSETENV])
!   HAVE_DECL_GETLOADAVG=1;    AC_SUBST([HAVE_DECL_GETLOADAVG])
!   REPLACE_MKSTEMP=0;         AC_SUBST([REPLACE_MKSTEMP])
!   REPLACE_PUTENV=0;          AC_SUBST([REPLACE_PUTENV])
!   REPLACE_STRTOD=0;          AC_SUBST([REPLACE_STRTOD])
!   VOID_UNSETENV=0;           AC_SUBST([VOID_UNSETENV])
  ])





reply via email to

[Prev in Thread] Current Thread [Next in Thread]