bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI, sync canonicalize-lgpl.c from glibc: Hurd fix


From: Bruno Haible
Subject: Re: FYI, sync canonicalize-lgpl.c from glibc: Hurd fix
Date: Wed, 23 Jul 2008 12:35:12 +0200
User-agent: KMail/1.5.4

Jim Meyering wrote:
> I noticed the following fix in glibc, so applied it here.

Thanks. I find the ChangeLog entry confusing, since the problem is not with
readlink, but with the terminating NUL byte that is added after the readlink
call. So, we don't need to write a readlink() override - readlink() by itself
is fine.

Bruno


*** ChangeLog.orig      2008-07-23 12:30:40.000000000 +0200
--- ChangeLog   2008-07-23 12:30:16.000000000 +0200
***************
*** 1,7 ****
  2008-07-23  Ulrich Drepper  <address@hidden>
  
!       * lib/canonicalize-lgpl.c (__realpath): readlink can write too
!       much into the buffer on platforms without PATH_MAX.
  
  2008-07-21  Eric Blake  <address@hidden>
  
--- 1,7 ----
  2008-07-23  Ulrich Drepper  <address@hidden>
  
!       * lib/canonicalize-lgpl.c (__realpath): Avoid buffer overflow after
!       readlink on platforms without PATH_MAX.
  
  2008-07-21  Eric Blake  <address@hidden>
  





reply via email to

[Prev in Thread] Current Thread [Next in Thread]