bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: c-stack: use libsigsegv when possible


From: Eric Blake
Subject: Re: c-stack: use libsigsegv when possible
Date: Sun, 20 Jul 2008 13:44:33 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.14) Gecko/20080421 Thunderbird/2.0.0.14 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 7/20/2008 11:21 AM:
|
| OK to apply? (Note: One needs the '(exit 77); exit 77' idiom only when
| a trap handler is installed which refers to $?. In most gnulib tests it
| is not needed.)

Yes, with one nit:

|     77) if grep 'stack overflow' t-c-stack2.tmp >/dev/null ; then
| !     if test -z "$LIBSIGSEGV"; then
| !       echo 'cannot tell stack overflow from crash; consider installing
libsigsegv' >&2
| !       exit 77
| !     else
| !       echo 'cannot tell stack overflow from crash, despite of libsigsegv' 
>&2

That comes across poorly in English; use either s/despite/in spite/ or
s/despite of/despite/.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkiDlaEACgkQ84KuGfSFAYCTHQCcCrcpUXLSwzr/ZqmnDmho/PT1
pDUAoKFiMX50TBAEaz/yHHlDkf7QPhiR
=OpMo
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]