[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: acl: trivial simplification
From: |
Jim Meyering |
Subject: |
Re: acl: trivial simplification |
Date: |
Sun, 08 Jun 2008 09:08:20 +0200 |
Bruno Haible <address@hidden> wrote:
> Still about POSIX-draft like ACLs. Now that the ACL triviality test has been
> moved into a function 'acl_access_nontrivial', the code that uses it can
> be simplified: coalesce two 'if' branches together. Then exploit the fact
> that chmod_or_fchmod has already the right return value convention.
>
> Committed, but please review nevertheless.
>
> 2008-06-07 Bruno Haible <address@hidden>
>
> * lib/set-mode-acl.c (chmod_or_fchmod): Document return value
> precisely.
> * lib/copy-acl.c (qcopy_acl): Trivial code simplifications.
I like that kind of change ;-)
copy-acl.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
Looks fine.