Re: Recommended headers include order

[Bruno Haible]

Eric Blake wrote:
> | +++ lib/error.h     2008-01-11 01:53:27.000000000 +0100
> | @@ -20,7 +20,7 @@
> |
> |  #ifndef __attribute__
> |  /* This feature is available in gcc versions 2.5 and later.  */
> | -# if __GNUC__ < 2 || (__GNUC__ == 2 && __GNUC_MINOR__ < 5) ||
> __STRICT_ANSI__
> | +# if __GNUC__ < 2 || (__GNUC__ == 2 && __GNUC_MINOR__ < 5)
> |  #  define __attribute__(Spec) /* empty */
> |  # endif
> 
> Doesn't changing files like error.h break sync with glibc?  Maybe it's
> worth asking the glibc list about their habits?

"Their" habits are as usual ([1], [2]):
  - when asked on libc-alpha, no answer,
  - when it's entered into the bug tracker, the reporter is attacked in
    a rude tone.

[1] http://sources.redhat.com/ml/libc-alpha/2006-04/msg00034.html
[2] http://sourceware.org/bugzilla/show_bug.cgi?id=2752

> | starting from 2.95.3, I found that __attribute__ works also with
> | __STRICT_ANSI__, therefore there is no need to define it away.
> 
> Seems fine to me

Applied.

Bruno