missing dependencies on 'fchdir'

[Bruno Haible]

Hi Jim,

findutils-4.3.6 uses some of the gnulib modules, in particular 'fts' and
'savedir'. On BeOS, this gives warnings and link errors due to the missing
fchdir function:

/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/chdir-long.c: In function 
`cdb_fchdir':
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/chdir-long.c:52: warning: 
implicit declaration of function `fchdir'

gcc -DHAVE_CONFIG_H -I. -I../..  -I../../intl -Wall -I/boot/home/config/include 
 -g -O2 -c fchmodat.c
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/at-func.c: In function 
`fchmodat':
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/at-func.c:66: warning: implicit 
declaration of function `fchdir'

gcc -DHAVE_CONFIG_H -I. -I../..  -I../../intl -Wall -I/boot/home/config/include 
 -g -O2 -c fchownat.c
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/at-func.c: In function 
`rpl_fchownat':
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/at-func.c:66: warning: implicit 
declaration of function `fchdir'

gcc -DHAVE_CONFIG_H -I. -I../..  -I../../intl -Wall -I/boot/home/config/include 
 -g -O2 -c fts.c
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/fts.c: In function `fts_close':
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/fts.c:565: warning: implicit 
declaration of function `fchdir'

gcc -DHAVE_CONFIG_H -I. -I../..  -I../../intl -Wall -I/boot/home/config/include 
 -g -O2 -c mkdirat.c
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/at-func.c: In function `mkdirat':
In file included from 
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/mkdirat.c:43:
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/at-func.c:66: warning: implicit 
declaration of function `fchdir'

gcc -DHAVE_CONFIG_H -I. -I../..  -I../../intl -Wall -I/boot/home/config/include 
 -g -O2 -c openat.c
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/openat.c: In function 
`openat_permissive':
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/openat.c:116: warning: implicit 
declaration of function `fchdir'

ftsfind.o: In function `main':
/boot/home/gnubuild/findutils-4.3.6/find/ftsfind.c:728: undefined reference to 
`fchdir'
./libfindtools.a(pred.o): In function `prep_child_for_exec':
/boot/home/gnubuild/findutils-4.3.6/find/ftsfind.c:758: undefined reference to 
`fchdir'
../lib/libfind.a(dircallback.o): In function `run_in_dir':
/boot/home/gnubuild/findutils-4.3.6/lib/ftsfind.c:111: undefined reference to 
`fchdir'
../lib/libfind.a(qmark.o): In function `multibyte_qmark_chars':
/boot/home/gnubuild/findutils-4.3.6/lib/ftsfind.c:126: undefined reference to 
`wcwidth'
../gnulib/lib/libgnulib.a(fts.o): In function `fts_close':
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/ftsfind.c:481: undefined 
reference to `fchdir'
../gnulib/lib/libgnulib.a(fts.o): In function `fts_read':
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/ftsfind.c:616: undefined 
reference to `fchdir'
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/ftsfind.c:736: undefined 
reference to `fchdir'
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/ftsfind.c:750: undefined 
reference to `fchdir'
../gnulib/lib/libgnulib.a(fts.o): In function `fts_children':
/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/ftsfind.c:758: undefined 
reference to `fchdir'
../gnulib/lib/libgnulib.a(fts.o):/boot/home/gnubuild/findutils-4.3.6/gnulib/lib/ftsfind.c:758:
 more undefined references to `fchdir' follow
collect2: ld returned 1 exit status

Here is a suggested fix: add the dependency to the 'fchdir' module, which is
known to provide a reasonably working fchdir replacement.

OK to apply, Jim?


2007-05-26  Bruno Haible  <address@hidden>

        * modules/chdir-long (Depends-on): Add fchdir.
        * modules/chdir-safer (Depends-on): Likewise.
        * modules/fts (Depends-on): Likewise.
        * modules/fts-lgpl (Depends-on): Likewise.
        * modules/openat (Depends-on): Likewise.
        * modules/savewd (Depends-on): Likewise.

*** modules/chdir-long  13 Oct 2006 12:40:23 -0000      1.9
--- modules/chdir-long  26 May 2007 19:55:08 -0000
***************
*** 7,12 ****
--- 7,13 ----
  m4/chdir-long.m4
  
  Depends-on:
+ fchdir
  fcntl
  openat
  mempcpy
*** modules/chdir-safer 13 Oct 2006 12:40:23 -0000      1.5
--- modules/chdir-safer 26 May 2007 19:55:08 -0000
***************
*** 7,12 ****
--- 7,13 ----
  m4/chdir-safer.m4
  
  Depends-on:
+ fchdir
  fcntl
  same-inode
  stdbool
*** modules/fts 8 Jan 2007 21:28:13 -0000       1.12
--- modules/fts 26 May 2007 19:55:08 -0000
***************
*** 11,16 ****
--- 11,17 ----
  cycle-check
  d-type
  dirfd
+ fchdir
  fcntl
  fcntl-safer
  hash
*** modules/fts-lgpl    3 Jan 2007 08:46:13 -0000       1.4
--- modules/fts-lgpl    26 May 2007 19:55:08 -0000
***************
*** 8,13 ****
--- 8,14 ----
  
  Depends-on:
  dirfd
+ fchdir
  i-ring
  openat
  stdbool
*** modules/openat      12 May 2007 08:54:55 -0000      1.19
--- modules/openat      26 May 2007 19:55:08 -0000
***************
*** 16,21 ****
--- 16,22 ----
  Depends-on:
  dirname
  extensions
+ fchdir
  gettext-h
  intprops
  lchown
*** modules/savewd      19 Dec 2006 05:38:34 -0000      1.4
--- modules/savewd      26 May 2007 19:55:08 -0000
***************
*** 9,14 ****
--- 9,15 ----
  Depends-on:
  dirname
  exit
+ fchdir
  fcntl-safer
  fcntl
  raise