bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: use of thread-unsafe localeconv in vasprintf


From: Ralf Wildenhues
Subject: Re: use of thread-unsafe localeconv in vasprintf
Date: Mon, 26 Mar 2007 09:00:41 +0200
User-agent: Mutt/1.5.14 (2007-03-20)

Hello Bruno,

* Bruno Haible wrote on Mon, Mar 26, 2007 at 04:18:35AM CEST:
> After testing on a few platforms, I applied this patch now.
>
> 2007-03-25  Bruno Haible  <address@hidden>
> 
>       * lib/vasnprintf.c: Include langinfo.h.
>       (VASNPRINTF): Prefer nl_langinfo over localeconv, since it's more
>       multithread-safe.
>       * m4/vasnprintf.m4 (gl_PREREQ_VASNPRINTF_DIRECTIVE_A): New macro.
[...]

Drive-by spotting:

> *** m4/vasnprintf.m4  7 Mar 2007 01:34:55 -0000       1.13
> --- m4/vasnprintf.m4  26 Mar 2007 02:08:17 -0000


> + # Extra prerequisites of lib/vasnprintf.c for supporting the 'a' directive.
> + AC_DEFUN([gl_PREREQ_VASNPRINTF_DIRECTIVE_A],
> + [
> +   AC_REQUIRE([gl_PRINTF_DIRECTIVE_A])
> +   if ! expr "$gl_cv_func_printf_directive_a" : ".*yes" > /dev/null; then

`if !' is not portable, please use
  if $cmd; then :; else

instead; I think you removed several other instances of this in the
patch already.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]