Re: one last snapshot before test release

[Jim Meyering]

Matthew Woehlke <address@hidden> wrote:
> Jim Meyering wrote:
>> I've made another snapshot:
>>     http://meyering.net/cu/coreutils-6.7-dirty.tar.gz
>>     http://meyering.net/cu/coreutils-6.7-dirty.tar.gz.sig
>> Please give it a try and report anything strange.
>> I expect to make a test release tomorrow.
>
> 'make && make check' is clean on AIX 5.1 (I only tested not-root,
> no-chgrp, nfs this round), but I get this on IRIX 6.5:
>
> cc-1153 cc: ERROR File = gettimeofday.c, Line = 105
>   Declaration is incompatible with previous "gettimeofday"
>           (declared at line 203 of "/usr/include/sys/time.h").
>
>     extern int gettimeofday (/* unspecified arguments */);

Thanks for the quick feedback.
That's fall-out from some of the recent gnulib changes
in that area.  Here's the fix I've just committed:

        * lib/gettimeofday.c (rpl_gettimeofday): Remove declaration
        of gettimeofday.  It would conflict with the one now always
        provided via sys_time_.h.  Reported by Matthew Woehlke, as
        an IRIX 6.5 build failure.

Index: lib/gettimeofday.c
===================================================================
RCS file: /sources/gnulib/gnulib/lib/gettimeofday.c,v
retrieving revision 1.13
diff -u -p -r1.13 gettimeofday.c
--- lib/gettimeofday.c  18 Jan 2007 16:15:42 -0000      1.13
+++ lib/gettimeofday.c  21 Feb 2007 07:56:56 -0000
@@ -102,8 +102,6 @@ rpl_gettimeofday (struct timeval *restri
 {
 #undef gettimeofday
 #if HAVE_GETTIMEOFDAY
-  extern int gettimeofday (/* unspecified arguments */);
-
 # if GETTIMEOFDAY_CLOBBERS_LOCALTIME
   /* Save and restore the contents of the buffer used for localtime's
      result around the call to gettimeofday.  */