[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnulib-tool: restore the ability to create a big testdir
From: |
Paul Eggert |
Subject: |
Re: gnulib-tool: restore the ability to create a big testdir |
Date: |
Thu, 12 Oct 2006 15:01:16 -0700 |
User-agent: |
Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) |
Ralf Wildenhues <address@hidden> writes:
> config-h is not the only problem child.
> fnmatch-posix and fnmatch-gnu are documented to collide as well.
That's OK. Part of my motivation for getting rid of "#ifdef
HAVE_CONFIG_H" is to remove unnecessary differences between
gnulib/lib/foo.c and coreutils/lib/foo.c. I'd want to do this even if
I can't remove all the collisions in gnulib. Those differences are a
maintenance hassle, in many ways.
>> Would anybody object if I changed all the other modules to be
>> compatible with config-h?
>
> This would break lib/argz.c.
Sorry, I don't follow. Is this because lib/argz.c is used in projects
that don't use AC_CONFIG_HEADERS? Which projects are they?
If there are actual projects that don't use AC_CONFIG_HEADERS then of
course we have to be cautious about assuming config-h. But if not,
then why wouldn't the following patch work for lib/argz.c?
--- argz.c.~1.7.~ 2006-08-28 23:15:20.000000000 -0700
+++ argz.c 2006-10-12 14:55:58.000000000 -0700
@@ -19,12 +19,10 @@
with this program; if not, write to the Free Software Foundation,
Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */
-#ifdef HAVE_CONFIG_H
-# if defined(LTDL) && defined LT_CONFIG_H
-# include LT_CONFIG_H
-# else
-# include <config.h>
-# endif
+#if defined(LTDL) && defined LT_CONFIG_H
+# include LT_CONFIG_H
+#else
+# include <config.h>
#endif
#include <argz.h>