Re: getlogin_r.m4 and host_os.m4

[Paul Eggert]

Ralf Wildenhues <address@hidden> writes:

>       * getlogin_r.m4 (gl_PREREQ_GETLOGIN_R): Require AC_GNU_SOURCE.
>       * host-os.m4 (gl_HOST_OS): Require AC_CANONICAL_HOST.

The host-os.m4 change looks fine, but the getlogin_r.m4 change (adding
AC_REQUIRE([AC_GNU_SOURCE])) looks a bit GNU-specific.  Wouldn't it be
better to depend on the 'extensions' module instead?  That would catch
similar problems in non-GNU systems.

(Come to think of it, doesn't a similar argument apply to the 30 or so
other uses of AC_GNU_SOURCE in gnulib?  I guess I can bring that up on
a different thread....)

I installed this:

2006-09-25  Paul Eggert  <address@hidden>

        * modules/clock-time (Maintainer): Add self.
        * modules/getlogin_r (Depends-on): Add extensions.

2006-09-25  Ralf Wildenhues  <address@hidden>

        * m4/host-os.m4 (gl_HOST_OS): Require AC_CANONICAL_HOST.

--- m4/host-os.m4       23 Jan 2005 08:06:57 -0000      1.8
+++ m4/host-os.m4       26 Sep 2006 06:34:23 -0000
@@ -1,6 +1,6 @@
-#serial 5
+#serial 6
 
-# Copyright (C) 2001, 2003, 2004 Free Software Foundation, Inc.
+# Copyright (C) 2001, 2003, 2004, 2006 Free Software Foundation, Inc.
 # This file is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
 # with or without modifications, as long as this notice is preserved.
@@ -12,6 +12,7 @@ dnl From Paul Eggert.
 # Define HOST_OPERATING_SYSTEM to a name for the host operating system.
 AC_DEFUN([gl_HOST_OS],
 [
+  AC_REQUIRE([AC_CANONICAL_HOST])dnl
   AC_CACHE_CHECK([host operating system],
     gl_cv_host_operating_system,
 
--- modules/clock-time  25 Sep 2006 17:35:50 -0000      1.1
+++ modules/clock-time  26 Sep 2006 06:34:23 -0000
@@ -18,4 +18,4 @@ License:
 GPL
 
 Maintainer:
-Jim Meyering
+Paul Eggert, Jim Meyering
--- modules/getlogin_r  22 Aug 2006 17:15:28 -0000      1.4
+++ modules/getlogin_r  26 Sep 2006 06:34:23 -0000
@@ -7,6 +7,7 @@ lib/getlogin_r.c
 m4/getlogin_r.m4
 
 Depends-on:
+extensions
 unistd
 
 configure.ac: