[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: unused variables and other nits in gnulib/m4
From: |
Ralf Wildenhues |
Subject: |
Re: unused variables and other nits in gnulib/m4 |
Date: |
Fri, 22 Sep 2006 20:09:58 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Hello Jim, Simon,
* Jim Meyering wrote on Fri, Sep 22, 2006 at 09:03:40AM CEST:
> Ralf Wildenhues <address@hidden> wrote:
> >
> > OK to apply these patches[...]
> A couple of nits:
> - fsusage.m4 needs a serial number update.
Done.
> - at least one other file does, too.
m4/ls-mntd-fs.m4 does.
> - mkdir-slash.m4's serial number was incremented twice :-)
As was sockpfaf.m4's.
> - for those that now include unistd.h,
> add AC_CHECK_HEADERS_ONCE(unistd.h),
I did that.
> or maybe even AC_REQUIRE([gl_HEADER_UNISTD]),
> or just depend on the `unistd' module and drop the #ifdefs,
> though I'm not sure the last will work for configure-time compiles.
I didn't do any of these. The replacement header is currently empty: it
would not help to declare `rmdir'. Besides, it won't work for configure
time compiles (easily).
Updated patches attached.
> How did you test these changes?
I used a megatest, as shown in another mail, and then manually inspected
each hard failure (be that autogen, configure, build), and searched all
config.log files for the keyword `warning' and some other suspicious
stuff.
> I've found it useful to compare the following (e.g., via coreutils),
> before and after the change:
> lib/config.h
> ./configure output
Yes. On my list of things to add was a test similar to the one in
Autoconf's testsuite; that would check that caching works as intended,
and that temporary files are cleaned up. There's a way to go though.
* Simon Josefsson wrote:
> I didn't test it, but at glance it seems fine to me.
Thanks. I've installed the two portions as below; I suppose Bruno will
have a say about the diff against the modules he maintains.
Cheers,
Ralf
simon2.diff
Description: Text document
jimpaul2.diff
Description: Text document