bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new module proposal: verror


From: Ralf Wildenhues
Subject: Re: new module proposal: verror
Date: Thu, 10 Aug 2006 15:51:34 +0200
User-agent: Mutt/1.5.12 (2006-08-10)

Hello Eric,

* Eric Blake wrote on Thu, Aug 10, 2006 at 03:08:38PM CEST:
> 
>       * gnulib-tool (func_import): Check for unexpanded gl_ macros.

This looks like a very good idea to me, in general; minor issues:

- gl_ES is a valid locale name,
- `LC_ALL=C grep "gl_[abd-z]" gnulib/m4/*' shows many non-cache
  variables, and some test result values that will spoil your nice plan.
  Maybe forbid `^gl_[A-Z]' only?

So, better would be
  m4_pattern_forbid([^gl_[A-Z]])
  m4_pattern_allow([^gl_ES])

the first of which is similarly used in coreutils/m4/prereq.m4
already (which in turn was part of Gnulib for a while).

For safety, looking at a couple of the more important gnulib-using
packages for other problematic cases seems prudent before actually
installing this.  I could not find a contender in a couple of packages
I grepped, though.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]