bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: memcmp module


From: Ralf Wildenhues
Subject: Re: memcmp module
Date: Mon, 3 Jul 2006 09:09:51 +0200
User-agent: Mutt/1.5.11-2006-06-19

Hello Jim,

* Jim Meyering wrote on Thu, Jun 29, 2006 at 01:57:36PM CEST:
> 
> How about leaving it in for a while longer, but adding some sort of
> assertion that will trigger if ever configure detects it's needed.
> 
> Here's what I did recently for coreutils:
> Note that it does provide a way to continue on with the build.
> 
> 2006-06-18  Jim Meyering  <address@hidden>
> 
>         * ftruncate.m4 (gl_FUNC_FTRUNCATE): If ftruncate is missing, make
>         configure fail, and request a bug report to inform us about it.
>         Add a comment that, barring reports to the contrary, in 2007 we'll
>         assume ftruncate is universally available.
*snip*

> +    if test x"$SKIP_FTRUNCATE_CHECK" != xyes; then
> +      AC_MSG_FAILURE([Your system lacks the ftruncate function.
> +       Please report this, along with the output of "uname -a", to the
> +       address@hidden mailing list.  To continue past this point,
> +       rerun configure with SKIP_FTRUNCATE_CHECK=yes set in the environment.
> +       E.g., env SKIP_FTRUNCATE_CHECK=yes ./configure])

Please do not teach users to set environment variables rather than pass
arguments to configure.
  ./configure SKIP_FTRUNCATE_CHECK=yes

has the same effect for your code, but happens to still work with a
later
  ./config.status --recheck

which may be issued by the user, or triggered by some makefile rules.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]