[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: canonicalize depends on pathmax.h
From: |
Bruno Haible |
Subject: |
Re: canonicalize depends on pathmax.h |
Date: |
Mon, 11 Jul 2005 13:30:07 +0200 |
User-agent: |
KMail/1.5 |
Jim Meyering wrote:
> * check-module (find_included_lib_files): Hard-code another
> pair of exceptions: fts.c includes fts-cycle.c and unistd-safer.h
> but the fts-lgpl module file (correctly) does not list those files.
Why are there two places where you note the exceptions? With the appended
patch, the two exception lists are merged into one, and no warnings appear.
Bruno
*** check-module.bak 2005-07-04 13:16:18.000000000 +0200
--- check-module 2005-07-10 14:12:10.000000000 +0200
***************
*** 144,160 ****
exists $inc{$line} && ! exists $special_non_dup{$line}
and warn "$ME: $file: duplicate inclusion of $line\n";
- # Some known exceptions.
- $file =~ /\bfull-write\.c$/ && $line eq 'full-read.h'
- and next;
- $file =~ /\bsafe-read.c$/ && $line eq 'safe-write.h'
- and next;
- $file =~ /\bhash\.c$/ && $line eq 'obstack.h'
- and next;
- $file =~ /\bfts\.c$/ &&
- ($line eq 'fts-cycle.c' || $line eq 'unistd-safer.h')
- and next;
-
$inc{$line} = 1;
}
close FH;
--- 144,149 ----
***************
*** 204,209 ****
--- 193,211 ----
# since we've made that exception solely to make the error
# module easier to use -- at RMS's request.
'lib/error.c:gettext.h' => 1,
+
+ # The full-read module shares code with the full-write module.
+ 'lib/full-write.c:full-read.h' => 1,
+
+ # The safe-write module shares code with the safe-read module.
+ 'lib/safe-read.c:safe-write.h' => 1,
+
+ # The use of obstack.h in the hash module is conditional, off by default.
+ 'lib/hash.c:obstack.h' => 1,
+
+ # The fts-lgpl module doesn't actually use fts-cycle.c and
unistd-safer.h.
+ 'lib/fts.c:fts-cycle.c' => 1,
+ 'lib/fts.c:unistd-safer.h' => 1,
);
my @t = sort keys %module_all_files;
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: canonicalize depends on pathmax.h,
Bruno Haible <=