[bug-gnulib] Re: size_max

[Simon Josefsson]

Paul Eggert <address@hidden> writes:

> Simon Josefsson <address@hidden> writes:
>
>> +Include:
>
> Instead of being empty, shouldn't the Include: section look like this?
> Otherwise, SIZE_MAX won't be defined on some platforms.
>
>   #include <limits.h>
>   #if HAVE_STDINT_H
>   #include <stdint.h>
>   #endif
>
> Admittedly this is a bit of a hassle.  Perhaps we should add
> a new file lib/size_max.h that contains the above code?

I think that would be cleaner.

>> +License:
>> +LGPL
>
> There's no LGPL'ed code in the proposed module.  It's licensed under
> these terms:
>
>    This file is free software; the Free Software Foundation
>    gives unlimited permission to copy and/or distribute it,
>    with or without modifications, as long as this notice is preserved.
>
> How about if we change the "License:" field to read "Preserve-notice",
> or something nice little phrase like that?

Would work, if gnulib-tool is modified, it currently look for "LGPL".

> Or, if we add a new file lib/size_max.h along the lines suggested
> above, then perhaps we can just keep it LGPLed.  That might be simpler
> than adding a new value to the License: field.

Yes.

>> +Maintainer:
>> +Simon Josefsson
>
> Shouldn't Bruno be the maintainer?  He wrote all the code.
> (Unless "Maintainer" means "maintainer of the module file" ....)

I don't know what the significance of the Maintainer field is.  I
think I may have "adopted" some modules which I didn't write nor know
extensively before too.