[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnulib] Re: snprintf
From: |
Paul Eggert |
Subject: |
Re: [Bug-gnulib] Re: snprintf |
Date: |
Fri, 01 Oct 2004 11:56:08 -0700 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) |
Simon Josefsson <address@hidden> writes:
> PS. These '/* Get X. */' comments feel a bit overworked...
Some like them (as they make it a bit easier to remove #includes when
they are no longer needed), but I don't (they're clutter). If you
don't like them either then let's get rid of them. I installed this:
2004-10-01 Paul Eggert <address@hidden>
* snprintf.c: Remove comments as to why each header is needed.
Index: snprintf.c
===================================================================
RCS file: /cvsroot/gnulib/gnulib/lib/snprintf.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -p -u -r1.4 -r1.5
--- snprintf.c 1 Oct 2004 13:27:20 -0000 1.4
+++ snprintf.c 1 Oct 2004 18:54:53 -0000 1.5
@@ -20,21 +20,14 @@
# include <config.h>
#endif
-/* Specification. */
#include "snprintf.h"
-/* Get va_list, va_start, va_end. */
#include <stdarg.h>
-/* Get free. */
#include <stdlib.h>
-/* Get memcpy, size_t. */
#include <string.h>
-/* Get vasnprintf. */
-#include "vasnprintf.h"
-
-/* Get MIN. */
#include "minmax.h"
+#include "vasnprintf.h"
/* Print formatted output to string STR. Similar to sprintf, but
additional length SIZE limit how much is written into STR. Returns
- Re: [Bug-gnulib] Re: snprintf,
Paul Eggert <=