[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnulib] several modules missing Files:
From: |
Paul Eggert |
Subject: |
Re: [Bug-gnulib] several modules missing Files: |
Date: |
Sat, 12 Jun 2004 23:34:52 -0700 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) |
Jim Meyering <address@hidden> writes:
> I wrote an ugly little script to look for files that are
> #include'd but not listed in some module's Files: section.
Nice idea; thanks.
> * modules/full-read (Files): Add lib/full-write.c.
> * modules/safe-write (Files): Add lib/safe-read.c.
Aren't these changes redundant? full-read depends on full-write, and
full-write has lib/full-write.c. Or perhaps you also meant to remove
that dependency? But that wasn't in the patch. A similar comment
applies to safe-write.
> * modules/pipe (Files): Add lib/wait-process.h.
This isn't enough, since pipe.c calls register_slave_process, which is
defined in wait-process.c. Sounds like it'd be cleaner to have the
pipe module depend on the wait-process module.
> * modules/stat (Files): Likewise. [Add lib/xalloc.h.]
stat.c calls xmalloc, so I'd say stat should depend on the xalloc module.
> * modules/xstrtol (Files): Add lib/error.h.
Similarly, xstrtol.h calls error, so I'd say that xstrtol should depend
on the error module.
How about this patch instead?
2004-06-12 Jim Meyering <address@hidden>
and Paul Eggert <address@hidden>
* modules/hash (Files): Add lib/xalloc.h.
* modules/pipe (Depends-on): Add wait-process.
* modules/stat (Depends-on): Add xalloc.
* modules/userspec (Files): Add lib/userspec.h.
* modules/xstrtol (Depends-on): Add error.
Index: modules/hash
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/hash,v
retrieving revision 1.4
diff -p -u -r1.4 hash
--- modules/hash 1 Jun 2004 03:49:49 -0000 1.4
+++ modules/hash 13 Jun 2004 06:27:09 -0000
@@ -5,6 +5,7 @@ Files:
lib/hash.h
lib/hash.c
m4/hash.m4
+lib/xalloc.h
Depends-on:
stdbool
Index: modules/pipe
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/pipe,v
retrieving revision 1.1
diff -p -u -r1.1 pipe
--- modules/pipe 3 Feb 2004 21:48:51 -0000 1.1
+++ modules/pipe 13 Jun 2004 06:27:09 -0000
@@ -8,6 +8,7 @@ lib/w32spawn.h
m4/pipe.m4
Depends-on:
+wait-process
error
exit
fatal-signal
Index: modules/stat
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/stat,v
retrieving revision 1.4
diff -p -u -r1.4 stat
--- modules/stat 18 Apr 2004 18:12:50 -0000 1.4
+++ modules/stat 13 Jun 2004 06:27:09 -0000
@@ -6,6 +6,7 @@ lib/stat.c
m4/stat.m4
Depends-on:
+xalloc
configure.ac:
gl_FUNC_STAT
Index: modules/userspec
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/userspec,v
retrieving revision 1.5
diff -p -u -r1.5 userspec
--- modules/userspec 3 Nov 2003 15:02:32 -0000 1.5
+++ modules/userspec 13 Jun 2004 06:27:09 -0000
@@ -3,6 +3,7 @@ Parse a `user:group' specifier (e.g. the
Files:
lib/userspec.c
+lib/userspec.h
m4/userspec.m4
Depends-on:
Index: modules/xstrtol
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/xstrtol,v
retrieving revision 1.4
diff -p -u -r1.4 xstrtol
--- modules/xstrtol 24 Jan 2004 07:22:34 -0000 1.4
+++ modules/xstrtol 13 Jun 2004 06:27:09 -0000
@@ -15,6 +15,7 @@ m4/xstrtol.m4
Depends-on:
exitfail
+error
configure.ac:
gl_XSTRTOL