[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?
From: |
Derek Robert Price |
Subject: |
[Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally? |
Date: |
Thu, 15 Apr 2004 16:18:15 -0400 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Derek Robert Price wrote:
> Hey all,
>
> I noticed that the fnmatch.c file is including alloca.h conditionally,
> based on HAVE_ALLOCA_H, as is regex.c. Shouldn't they both be able to
> assume that alloca.h can be included, as vasnprintf.c does, since both
> the fnmatch and regex modules are listed as being dependent on the
> alloca module?
>
> Derek
Similarly, vasnprintf.c & regex.c are switching on HAVE_ALLOCA, which
they should also be able to assume. In fact, on systems where
lib/alloca.c needs to be compiled, I think that HAVE_ALLOCA often
isn't being defined and thus the function is compiled and not used by
vasnprintf or regex.
fnmatch.c appears to define HAVE_ALLOCA as well, then not use it.
This can probably be removed.
Derek
- --
*8^)
Email: address@hidden
Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFAfu4GLD1OTBfyMaQRAqQXAKCdYCngTm5qCD86oLpuOD0+9C0JsgCdFd6I
jqW7pFh/8z1k6P0qSgDYmuE=
=60vO
-----END PGP SIGNATURE-----
- [Bug-gnulib] fnmatch.c includes alloca.h conditionally?, Derek Robert Price, 2004/04/15
- [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?,
Derek Robert Price <=
- Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?, Derek Robert Price, 2004/04/19
- Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?, Bruno Haible, 2004/04/20
- Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?, Derek Robert Price, 2004/04/20
- Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?, Paul Eggert, 2004/04/20
- Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?, Derek Robert Price, 2004/04/20
- Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?, Paul Eggert, 2004/04/20
- Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?, Derek Robert Price, 2004/04/20
- Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?, Derek Robert Price, 2004/04/23