[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnulib] Module: poll (take 2)
From: |
Bruno Haible |
Subject: |
Re: [Bug-gnulib] Module: poll (take 2) |
Date: |
Thu, 20 Feb 2003 14:10:46 +0100 (CET) |
Paolo Bonzini writes:
> The attached revised patch fixes all of the mismatches that were found in the
> original implementation of POSIX. It also includes the aclocal file and
> modules/poll.
Thanks a lot. I've added this to the repository, with a few tiny
modifications:
- poll.c: Define a fallback for EOVERFLOW outside the function. This
minimizes the number of #if inside a function, which is a goal for Jim.
- poll.c, poll_.h: GNU coding style.
- poll.m4: Simplify test - $ac_cv_func_poll is guaranteed to be either
"yes" or "no' after AC_REPLACE_FUNCS(poll). Also added a test for
HAVE_SYS_TIME_H (this is not documented to be part of AC_HEADER_TIME).
- modules/poll: Use <poll.h>, not "poll.h" - this is what POSIX compliant
programs should look like.
- modules/poll: Add m4/poll.m4 to the filelist.
- modules/poll: Add poll.h to DISTCLEANFILES, otherwise, if after
building on a platform not supporting poll you do "make distclean"
and build on a platform with built-in poll, you'd get strange errors
because it would use the leftover lib/poll.h.
Bruno