Re: [Bug-gnubg] Replace GtkCList with GtkTreeView

[Jeremy Moore]

Oops, one correction to the previous patch. I just noticed that I lost
a translation marker.

Index: gtkgamelist.c
===================================================================
RCS file: /sources/gnubg/gnubg/gtkgamelist.c,v
retrieving revision 1.45
diff -u -r1.45 gtkgamelist.c
--- gtkgamelist.c 29 Jun 2016 19:31:26 -0000 1.45
+++ gtkgamelist.c 5 Jul 2016 11:50:39 -0000
@@ -282,7 +282,7 @@
     renderer = gtk_cell_renderer_text_new();
     g_object_set(renderer, "ypad", 0, NULL);
     gtk_cell_renderer_set_alignment(renderer, 1.0, 0.5);
-    column = gtk_tree_view_column_new_with_attributes("#", renderer,
"text", GL_COL_MOVE_NUMBER, NULL);
+    column = gtk_tree_view_column_new_with_attributes(_("#"),
renderer, "text", GL_COL_MOVE_NUMBER, NULL);
     gtk_tree_view_column_set_alignment(column, 1.0);
     gtk_tree_view_column_set_sizing(column, GTK_TREE_VIEW_COLUMN_FIXED);
     gtk_tree_view_append_column(GTK_TREE_VIEW(pwGameList), column);

Sorry about that.

Jeremy

On Sun, Jun 26, 2016 at 10:33 PM, Philippe Michel
<address@hidden> wrote:
>> [...] I've tried to fudge the style of the new widget to look similar to
>> the old one, but there are visible differences in the column headings and
>> row  height. In the end, a different widget looks different, but it should
>> at least be more consistent with the move list and hint window.
>>
>> Comments are welcome, particularly if anyone knows a way to reduce the row
>> height while keeping the text vertically centred.
>
>
> I'm not sure it is that important to tweak the row height. As you write, it
> is now the same as the other windows and (compared to an adjacent hint
> window) the difference could be a kind of optical illusion because the hint
> window is filled with columns of numbers while the moves list has much more
> white space on each line.
>
> Maybe there are some typographical tricks that would alleviate this. A light
> grey background instead of a white one ? Something like that.
>
> FWIW, on my main machine the difference stands out (but the new display
> feels neither clearly worse nor better, just different) while in an Ubuntu
> 16 virtual machine where the default font is bolder the change seems less
> important and the new lighter version looks better to me.
>
>
> _______________________________________________
> Bug-gnubg mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/bug-gnubg