bug-gnubg
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnubg] bug report


From: Christian Anthon
Subject: Re: [Bug-gnubg] bug report
Date: Sun, 12 Nov 2006 00:32:37 +0100


I believe this is a crash in CreateGnubgDirectory(). I'm not sure what
happens, but I can reconstruct bug at my system.


Sigh. The filename used in mkdir (and access) is supposed to be in the
windows filename locale. The szHomedirectory is in UTF8, so there you
have it. I have fixed this in my own version of
CreateGnubgDirectory(), but the bug will exist where ever
szHomedirectory, so I'm not going to check it in before I review the
entrie code.

Here is a diff for you to try out Øystein:

RCS file: /sources/gnubg/gnubg/gnubg.c,v
retrieving revision 1.646
diff -r1.646 gnubg.c
84a85
#include <glib/gstdio.h>
6790c6791
<   if ( access ( sz, F_OK ) ) {
---
  if ( !g_file_test(sz, G_FILE_TEST_EXISTS) ){
6794,6798c6795
<     if ( mkdir ( sz
< #ifndef WIN32
<                  , S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH
< #endif
<                  ) < 0 ) {
---
    if ( g_mkdir ( sz, 0700) < 0 ) {

Christian.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]