bug-gnubg
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Réf. : Re: [Bug-gnubg] segfault when accessing help/commands on latest


From: Massimiliano . Maini
Subject: Réf. : Re: [Bug-gnubg] segfault when accessing help/commands on latest gnubg(linux)
Date: Fri, 7 Apr 2006 12:29:44 +0200

>I've found the bug, line 1627 of gnubg.c - where acSetImport is defined;
>this list doesn't end in a null entry - so
>   { NULL, NULL, NULL, NULL, NULL }
>needs to be added at 1630.
>
>Also the Ctrl+H shortcut is missing from the menu definition - line
>2260ish of gtkgame.c - second paramater should be "<control>H".

I confirm that both fixes work fine for me (WinXP).

>If someone could check these in I would be grateful - my computer still
>isn't connect up at home...

I can't, but if somebody can, please commit also these 2 :


1- gtkgame.c, line 9907 :

>if (!GtkGetEnv(env))
--
<if (GtkGetEnv(env))

2- database.py, line 602 :

>sqlfile = open("gnubg.sql", "r")
--
<if self.games :
<  sqlfile = open("gnubg.game.sql", "r")
<else :
<  sqlfile = open("gnubg.sql", "r")

1st fix explains why I was able to add matches to the db from the command
line
version of gnubg, but not from the gui version.

2nd fix allow to create the database according to what is specified in
the file database (there's a "flag" that allows to chose if games have
to be logged in the db or not).


MaX.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]