Re: [Bug-gnubg] Coloured moves in game list and request

[Jon Kinsey]

Joern Thyssen wrote:

> On Wed, Jun 16, 2004 at 11:12:08AM +0100, Jon Kinsey wrote
>
> > Joern Thyssen wrote:
> >
> > > I think we're talking about the highlighting of the actual move in the
> > > analysis widget (i.e., hint + analysis). There is a style called
> > > "movelabel" in gnubg.gtkrc. I wrote some
> > > comments in gnubg.gtkrc yesterday and assumed it was used for highliting
> > > the move, but it's not used anywhere in the code.
> > >
> > > Didn't you write the other day that you would change the analysis widget
> > > to use a style from gnubg.gtkrc or did you just write that you intended
> > > to change it that way? Hmm, I'm only 29 and my memory is already
> > > failing...  :-)
>
> > Anyway a quick look at the code and it looks like it uses the 
> > HighlightColourTable and the SetHighlightColour command.  I guess this 
> > should be removed and the value read from the gnubg.gtkrc file.
> >
> > I'll have a look at it later today.

Turns out it's quite straight forward - I've just checked in the change.

The movelabel style was being used, it's the style of the unfinished 
move string, showing in the bottom right.  I guess it's ok to share the 
settings for this - or perhaps they should be two different styles?

I'm not sure about the reference counting of the styles in the new code 
I've added, I haven't done any - hopefully gtk is getting them all 
correct...

Jon

signature.asc
Description: OpenPGP digital signature