Re: [Bug-gnubg] Generate bear off db(s) for Win32

[Joern Thyssen]

On Mon, Dec 02, 2002 at 12:21:25PM +0100, Øystein Johansen wrote
> >> I don't see any practical reasons why libxml should be needed to build the
> >> database, since it's not taking matchscore into account. Or am I wrong 
> again?
> >
> >makebearoff needs eval.o for GenerateMoves. eval.o needs matchequity.o
> >for match equities. matchequity.o needs libxml for parsing match equity
> >files.
> 
> Yes, I see!
> 
> >The only way to solve this is by cutting eval.o and matchequity.o into
> >smaller pieces.
> 
> Why doesn't it help if eval.o and matchequity.o is recompiled without 
> HAVE_XML2 defined?

It would! But it's impossible with the current structure: We would need
two different config.h: one for compiling gnubg and one for compiling
makebearoff. This is very ugly! 

It's way better to clean up the code: move the XML part of matchequity
to a new file parsemet.c (or whatever). 

> > This might be a good exercise anyway as eval.c is around
> >6k lines and it contains functions that really don't belong in eval.c
> >(e.g., PathSearch).
> 
> Yes, a cleanup here would be nice. I can take a look at this in the weekend I 
> guess. (If no one else voluenteers for the task.)

I'll clean-up matchequity.c.

Jørn

-- 
Joern Thyssen, PhD
Vendsysselgade 3, 3., DK-9000 Aalborg, Denmark
+45 9813 2791 (private) / +45 2818 0183 (mobile) / +45 9633 7036 (work)
Note: new mobile number!