Re: [Bug-gnubg] Strange analysis of double

[Joern Thyssen]

On Tue, Aug 06, 2002 at 11:32:03AM +0200, Jim Segrave wrote
[snip]
> This is with a gnubg built from CVS taken 6 Aug, 8AM GMT. I noticed it last
> night with a gnubg built from yesterday morining's CVS as well.
> 
> Looking at eval.c, in FindBestCubeDecision:
>     4550   if ( ( arDouble[ OUTPUT_TAKE ] >= arDouble[ OUTPUT_NODOUBLE ] ) &&
>     4551        ( arDouble[ OUTPUT_DROP ] >= arDouble[ OUTPUT_NODOUBLE ] ) ) {
> 
> This if fails because DP < ND, so we go to the else (line 4596) and following.
> 
>     4604     if ( arDouble [ OUTPUT_NODOUBLE ] > arDouble [ OUTPUT_TAKE ] ) {
> This if fails, we go to the else on line 4636, since DT > ND > DP
>     4636     else
>     4637 
>     4638       /* 3. DT >= ND > DP: Too good, pass */
>     4639 
>     4640       return ( pci->fCubeOwner == -1 ) ? 
>     4641         DOUBLE_PASS : REDOUBLE_PASS;
>     4642 
> 
> Which seems not to match the comments :-)

You are absolute right -- it should be

return ( pci->fCubeOwner == -1 ) ? TOOGOOD_PASS : TOOGOODRE_PASS;

For some unknown reason I introduced this in 1.165.

Jørn

-- 
Joern Thyssen, PhD
Vendsysselgade 3, 3., DK-9000 Aalborg, Denmark
+45 9813 2791 (private) / +45 2077 2689 (mobile) / +45 9633 7036 (work)