On Tue, Mar 15, 2022 at 03:45:24AM +0100, Mohammad Akhlaghi wrote:
Dear all,
After the long wait, I am happy to say that Gnuastro 0.17 is now
finally ready for release. Since the last alpha-release there have
been _many_ updates (see [1]). So before the official Gnuastro 0.17
release (during the weekend), I am sharing this second test release.
Hi Mohammad,
Thanks for the heads-up and another test release. It builds fine here
on FreeBSD, but there's a minor annoyance.
The bin/script/fits-view.in' script has /bin/bash shebang, which is a
linuxism. At a quick glance it does not use things like [[ or arrays
and thus should be POSIX shell compatible => #!/bin/sh. Could you
confirm and adjust the shebang accordingly?
There are a few stylistic bugs in it: test(1) equality operator is =
(single), not == (double), albeit the latter is supported because it
is apparently too hard to fight the finger memory of many. :)
Then, [ $ds9mode = "wcs" ] || [ $ds9mode = "img" ] I'd rewritten as
[ "$ds9mode" = wcs -o "$ds9mode" = img ] which is both shorter and
implies only one test(1) invocation. Note that you don't have to
quote static strings, only the variables (as they could expand to an
empty string).
There are some old-school constructs like x"$hdu" = x, yet all modern
shell implementations handle empty strings (when properly quoted) just
fine and do not require x-escaping. Also, test(1) has a dedicated
operator for testing string emptiness, -z.
There's some excessive vertical whitespace which could be trimmed.
./danfe