Re: patch troubles with CRLF's again

[Andreas Gruenbacher]

On Thursday, 1 September 2005 8:06:27 Mike Frysinger wrote:
> we're using patch-2.5.9 in Gentoo along with this CRLF patch:
> http://lists.gnu.org/archive/html/bug-gnu-utils/2005-05/msg00012.html
> we started using this patch after some patches were being rejected by 2.5.9
> but were working with 2.5.4

Patch strips the trailing CRs as intended. Since the files being patch also 
have CRLF line endings, this causes the patch to fail. It is impossible to 
always get this right, we can only make patch do the right thing for what it 
is mainly intended to do. (Paul already discussed this in [1].)

We could turn off the CR stripping heuristic with the --binary option though; 
I don't see any disadvantages. (Currently, --binary doesn't do anything on 
POSIX systems.)

[1] http://lists.gnu.org/archive/html/bug-gnu-utils/2005-05/msg00006.html

Thanks,
Andreas