Re: Patch bug - trips assertion

[Andreas Gruenbacher]

On Monday, 3 September 2007 10:31:14 Clarence Dang wrote:
> Please save the attached files and try the following:
>
> ~~~~
> $ patch --version
> patch 2.5.4
>
> $ patch -p0 < misleading-no-newline-at-file-assert-fail.diff
> patching file kpMainWindow_Tools.cpp
> patch: util.c:415: savebuf: Assertion `s && size' failed.
> Aborted
> ~~~~
>
> The cause is the last line of the diff, "\ No newline at end of file", as
> the file-to-be-patched does not actually end there.

Thank you for the bug report. The bug still exists in version 2.5.9.

The assertion simply seems wrong. In case you are still interested in this 
bug, a fixed version is available in the git repository of 
https://savannah.gnu.org/projects/patch on the "testing" branch:

  git clone git://git.savannah.gnu.org/patch.git
  cd patch
  ./autogen.sh
  ./configure
  ./make

Andreas