Re: address@hidden: [PATCH] sharutils-4.3.80: configure.ac tweak to build uuencode/uudecode OOTB on Cygwin]

[Bruce Korb]

Hi, guys, I did not notice the switch to single quotes.
Single quotes pass through the '$(XXX)' construct.
I was thinking "shell script" instead of "makefile script",
since "configure.ac" is the direct predecessor to a script.
It seems more flexible to fully evaluate "ADD_PROG" in
the configure script anyway, so I'll leave it as:

> > > > +  ADD_PROG="uudecode${EXEEXT} uuencode${EXEEXT}"

(thus curly braces are required....)  That leaves @ADD_PROG@
usable in a configurable shell script, too.  (Were one ever to
do that...)

Thanks again :) - Bruce

On Wednesday 08 June 2005 01:25 am, Corinna Vinschen wrote:
> On Jun  7 21:21, Bob Proulx wrote:
> > Bruce Korb wrote:
> > > Thank you for the patch.  I have applied it, substituting
> > > '{' for '(' and '}' for ')'.  Next release (not too far away,
> > 
> > Shouldn't Makefile variables use the smooth parenthesis, not the curly
> > ones like the shell?  I believe GNU make allows either.  But that is
> > not true of all make programs.  The V7 make documentation only
> > specifies $(string).  POSIX requires both.  All of the examples for
> > GNU make and GNU autoconf that I can find suggest $(string).
> > 
> > > > -  ADD_PROG="uudecode uuencode"
> > > > +  ADD_PROG='uudecode$(EXEEXT) uuencode$(EXEEXT)'
> > > > -  ADD_PROG="uudecode uuencode"
> > > > +  ADD_PROG='uudecode$(EXEEXT) uuencode$(EXEEXT)'
> > 
> > If those end up in a Makefile aren't the $(EXEEXT) usage correct?
> 
> Thanks for applying, Bruce.  But yes, parenthesis should be more correct
> than curly brackets.