Re: OS/2 Patches (4)

[Bruno Haible]

Andreas Buening writes:

> ---------------------------
> --- old/gettext-0.11.5/src/msgfilter.c  Tue Apr 23 11:33:34 2002
> +++ gnu/gettext-0.11.5/src/msgfilter.c  Sat Oct 19 21:05:48 2002
> @@ -37,7 +37,7 @@
>  #endif
> 
>  /* Get fd_set.  */
> -#ifdef _AIX
> +#if defined(_AIX) || defined(__EMX__)
>  # include <sys/select.h>
>  #endif
> ---------------------------

Why this? EMX <sys/types.h> already defines fd_set and the FD_* macros.
So what is <sys/select.h> good for?

> It's a bad idea to redefine symbols from a library in a program,
> program_name, to be exactly. I renamed it to local_program_name.

It'd better to declare it 'extern' instead.

> I don't know who maintains the lib subdirectory.

You can see that by looking at the lib subdirectory's ChangeLog.

Bruno