[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Suggested patch for libintl (gettext 0.10.40) on Win32
From: |
Tor Lillqvist |
Subject: |
Suggested patch for libintl (gettext 0.10.40) on Win32 |
Date: |
Tue, 25 Sep 2001 00:58:41 +0300 (FLE Daylight Time) |
Bruno Haible writes:
> * Querying the registry is totally unacceptable. It contributes to
> system instability.
But storing stuff like package installation directory in the Registry
is a "natural" thing on Windows, isn't it? Environment variables
aren't much used. Anyway, it would be up to the packager of some
software (who is probably using some installer-builder, if the
application is end-user oriented, and not just something for hackers)
to decide whether to store the end-user-chosen installation directory
in the Registry or not.
> Furthermore, in the implementation you propose,
> it is impossible to use two different versions of some package
> simultaneously, installed in different directories.
Well, that's normal on Windows ;-( If you mean two different
*numbered* versions, one could always include the version number in
the Registry key.
> * Use of "libintl-%d.dll" is too fragile. Some people who create gettext
> binaries will want to use different conventions, e.g. rename the dll
> to intl.dll or so. Please use a more tolerant technique, for example
> list all the DLLs used by the process, then see using VirtualQuery
> in which one the code being executed lies.
That might be a good idea, true.
> Maybe a WinMain() function in the DLL can help also?
That would indeed be easier, then you get the HMODULE for the DLL
directly, which can be passed to GetModuleFilename().
--tml