Re: [PATCHes] gawk-3.1.0 build problems under DJGPP

[Scott Deifik]

Greetings. Re this:

| From: "Peter J. Farley III" <address@hidden>
| 
| Below are diffs for the current gawk-3.1.0 tarball to improve building 
| under DJGPP/MS-DOS environments.  The problems resolved are:
|
| [Text deleted]
| 
| 4.    test/Makefile was updated to make the "manyfiles" test work on 
| DJGPP/MS-DOS (needed '\015' in argument to tr to strip CR's as well as 
| LF's), to use ";" as a path separator in the awkpath test and to bypass 
| the "pid" and "clos1way" tests under DJGPP, which doesn't implement pid 
| or ppid in the same way *ix systems do, nor can it implement the "|&" 
| internet functionality.  The diff is to tests/Makefile.am.
| 
| 5.    The script fixvers was updated to use $CMP instead of cmp, and the 
| Makefile.am file was updated to call fixvers using the syntax 
| "CMP=$(CMP) ./fixvers -v" (and "-p") so that make can be invoked under 
| DJGPP using "make CMP=diff".
| 
| This change *should* probably be to test for DJGPP in the main Makefile 
| or maybe in configure and select "diff" instead of "cmp" for DJGPP 
| build environments, but I didn't get the tuits for that change yet.
| 

| 
| I do realize that the choices I made for most of these changes could 
| and probably should be handled better, but they did allow me to build 
| and successfully test gawk-3.1.0 under DJGPP copying only 
| pc/gawkmisc.pc to the main build directory, with no other changes.

     Thank you for your patches.  Traditionally, it has been hard to
compile and test gawk in DOS environments.  For that reason, we have
maintained two separate files: pc/makefile for building and
pc/makefile.tst for testing.  Together, these work for both DJGPP &
Microsoft C v8 (among other compilers).  For instance, in
pc/makefile.tst, CMP defaults to using diff, as you suggest.
     I'm personally in favor of making the main distribution able to
handle DOS-specific needs (meaning various DOS-based compilers and
environments) if the changes would serve all/most environments.  The
only question is what to do when DOS has it's own way of doing things.
At that point, the decision of whether or not to specifically test for
the different need is a judgement call.
     I'm not sure what the final determination will be about each of
your (good) suggestions, but I just wanted to thank you for your input
and let you know about pc/makefile.tst (in case you were unaware).

Regards,
        Scott