Regression in rcparse.y

[Roger Sayle]

The following patch to binutils/rcparse.y

> 2000-06-13  DJ Delorie  <address@hidden>
>
> rcparse.y (control): ICON controls take an id as the first
> parameter, not an optional string.  Also, call new convenience
> function that takes res_id's.

causes windres to reject syntactically valid resource files.
The first parameter to ICON must be a quoted string containing
the resource id, not the resource id itself, as required by the
above change.

The syntax is explained in the relevant Microsoft documentation,
http://msdn.microsoft.com/library/psdk/winui/rc_0vxo.htm

Indeed, not quoting the first parameter to ICON causes error
"RC2104: undefined keyword or key name: myicon" in Microsoft's
resource compiler, RC.EXE. [Version 5.00.1472.1].



The probable cause for confusion, as demonstrated by the difference
between the grammar and the example on the above page, is that the
grammar prior to the above patch was also incorrect.  The first
argument to ICON should not be an "optstringc", but a "stringoptc",
where the quoted string is required but the following comma is
optional.

This was described in my post to the binutils list last December,
http://sources.redhat.com/ml/binutils/1999-12/msg00121.html

Roger
--
Roger Sayle,                         E-mail: address@hidden
Bioinformatics Group, Metaphorics,   WWW: http://www.metaphorics.com/
Office 104, 441 Greg Avenue,         Tel: (+1) 505-954-3281
Santa Fe, New Mexico, 87501.         Fax: (+1) 505-989-1200