PSPP-BUG: [bug #52045] pc+-file-reader.c: Wrong usage of pcp_error

[Friedrich Beckmann]

URL:
  <http://savannah.gnu.org/bugs/?52045>

                 Summary: pc+-file-reader.c: Wrong usage of pcp_error
                 Project: PSPP
            Submitted by: beckmanf
            Submitted on: Sat 16 Sep 2017 12:41:52 PM UTC
                Category: System/Portable File I/O
                Severity: 5 - Average
                  Status: None
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: None
                  Effort: 0.00

    _______________________________________________________

Details:

I get the following warning when compiling pspp on MacOS with clang:


../pspp/src/data/pc+-file-reader.c:224:18: warning: expression which evaluates
to zero treated as a null pointer constant of type 'struct pcp_reader *'
[-Wnon-literal-null-conversion]
      pcp_error (ME, 0, _("%s: stat failed (%s)."),
                 ^~
../pspp/src/data/pc+-file-reader.c:230:18: warning: expression which evaluates
to zero treated as a null pointer constant of type 'struct pcp_reader *'
[-Wnon-literal-null-conversion]
      pcp_error (ME, 0, _("%s: file too large."), fh_get_file_name (r->fh));
                 ^~
2 warnings generated.


The first argument of pcp_error should be a pointer but not a message type. I
think it should be replaced with msg but I am not sure.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52045>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/